From c05993dcba517ca235342b3c44f4d03be9b5764c Mon Sep 17 00:00:00 2001
From: andis <andis@fet.at>
Date: Wed, 31 May 2023 21:56:01 +0200
Subject: [PATCH] create pad rework

---
 fet2020/documents/api.py | 7 +++++--
 fet2020/intern/models.py | 5 +++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/fet2020/documents/api.py b/fet2020/documents/api.py
index d9ea4127..4212dea3 100644
--- a/fet2020/documents/api.py
+++ b/fet2020/documents/api.py
@@ -82,9 +82,12 @@ def create_pad(padID, text="helloworld"):
 
             epc.createGroupPad(groupID=group["groupID"], padName=padID, text=text)
             logger.info(f"neues Pad erzeugt: {padID}")
+        
         return padID
-
-    return None
+    if __pad_exists(padID=padID): 
+        return padID
+    else: 
+        raise Exception("Tried to create pad but failed!")
 
 
 def get_pad_html(padID):
diff --git a/fet2020/intern/models.py b/fet2020/intern/models.py
index 09ba31e3..48b95ac1 100644
--- a/fet2020/intern/models.py
+++ b/fet2020/intern/models.py
@@ -172,8 +172,9 @@ class Etherpad(models.Model):
 
         if self.etherpad_key is None:
             self.etherpad_key = create_pad(pad_name)
-            if self.etherpad_key is None:
-                raise ValidationError(f"Etherpad '{pad_name}' konnte nicht erstellt werden.")
+
+        if self.etherpad_key is None:
+            raise ValidationError(f"Etherpad '{pad_name}' konnte nicht erstellt werden. This should never happen!")
 
     @property
     def etherpad_html(self):