Fixed Bug when loading from tiss + typo in lvas_controller

The Bug would ALWAYS appear if Pruefungsinformation is empty at submission.
The Fix replaces the empty string with an dummy div-block.
This maybe has to be checked for all input fields.
This commit is contained in:
Thomas Blazek
2014-04-01 10:25:44 +02:00
parent fcdbb2248a
commit 5aedfa752e
2 changed files with 5 additions and 5 deletions

View File

@@ -52,7 +52,7 @@ class LvasController < ApplicationController
@lva = Lva.find_by_id(params[:lva_id]) @lva = Lva.find_by_id(params[:lva_id])
@lva.load_tissdata("-2013W") @lva.load_tissdata("-2013W")
if @lva.save if @lva.save
redirect_to @lva , notice: 'Lva von TISS geleaden.' redirect_to @lva , notice: 'Lva von TISS geladen.'
else else
redirect_to @lva, action: :compare_tiss redirect_to @lva, action: :compare_tiss
end end
@@ -64,7 +64,6 @@ class LvasController < ApplicationController
# POST /lvas.json # POST /lvas.json
def create def create
@lva = Lva.new(params[:lva]) @lva = Lva.new(params[:lva])
respond_to do |format| respond_to do |format|
if @lva.save if @lva.save
@lva.add_semesters @lva.add_semesters

View File

@@ -91,11 +91,12 @@ class ModulsController < ApplicationController
lva.desc=l["desc"] lva.desc=l["desc"]
lva.semester=Semester.where(:id=>l["semester_ids"].map(&:to_i)) lva.semester=Semester.where(:id=>l["semester_ids"].map(&:to_i))
lva.stunden=l["stunden"] lva.stunden=l["stunden"]
lva.pruefungsinformation=l["pruefungsinformation"] pr =l["pruefungsinformation"]
lva.pruefungsinformation= (pr.empty?) ? "<div></div>" : pr
lva.lernaufwand=l["lernaufwand"] lva.lernaufwand=l["lernaufwand"]
lva.typ=l["typ"] lva.typ=l["typ"]
lva.save lva.save
@newlvas<<lva @newlvas<<lva #
end end
@lvas=@newlvas @lvas=@newlvas
if @newlvas.map(&:valid?).all? if @newlvas.map(&:valid?).all?
@@ -121,7 +122,7 @@ class ModulsController < ApplicationController
lva.lvanr=l["lvanr"] lva.lvanr=l["lvanr"]
lva.load_tissdata("-"+ l["sem"]) lva.load_tissdata("-"+ l["sem"])
lva.modul<<@modul lva.modul<<@modul
@lvas<<lva @lvas<<lva #
end end
end end
render 'edit_lvas' render 'edit_lvas'