improve tests for lva

This commit is contained in:
2019-01-05 16:18:30 +01:00
parent f7f8937197
commit ff20774889
2 changed files with 19 additions and 4 deletions

View File

@@ -98,7 +98,7 @@ class Lva < ActiveRecord::Base
url
end
# this should be more DRY
def load_tissdata
urlp="https://tiss.tuwien.ac.at/api/course/"+ lvanr.to_s.gsub(".","")+"-"
begin
@@ -187,7 +187,8 @@ class Lva < ActiveRecord::Base
end
end
# Why is this an instance method??
# How is it used?
def update_multiple(hash)
newlvas=[]
params["lvas"].each do |i,l|
@@ -222,7 +223,7 @@ class Lva < ActiveRecord::Base
lecturers.map { |l| l.name }
end
end
# is this used? in which context?
def self.update_multiple_with_modul(hash,modul)
newlvas=[]
hash.each do |i,l|
@@ -248,7 +249,7 @@ class Lva < ActiveRecord::Base
end
# is this used? in which context?
def read_et_forum
lva=self
url=lva.forumlink